237446 - In <createProfileWizard.js>, "Error: newProfileRoot has no properties"

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

{{
Error: newProfileRoot has no properties
Source File: chrome://communicator/content/profile/createProfileWizard.js
Line: 109
}}

Steps:
1. ... Create Profile
2. ... Choose Folder
3. Cancel (without choosing anything)

Updating:
*(A.To) nobody#mozilla.org -> me

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <createProfileWizard.js>

Bug fix,
plus a little cleanup.

Comment 2

[Conrad Carlen (not reading bugmail)]

I like the fix, of course, but I'm not sure about the cleanup. For example:

-  var currentProfileName = document.getElementById("profileName").value;
   var profilePathAndName = gProfileRoot.clone();
 
-  profilePathAndName.append(currentProfileName);
+  profilePathAndName.append(document.getElementById("profileName").value);

It's handy, for debugging purposes, to have the local var.
Unless there's a significant cost for using local vars, I'd keep them.

CC'ing Ben as he might know better on this issue.

Also, I'm a little leery of whitespace cleanup in JS. At least with a compiled
language, you can compile and run a binary comparison on the before and after
object code to ensure equality.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) <createProfileWizard.js> [Checked in: Comment 8]

Av1, with comment 2 suggestion(s);
     == without the "used-once" |var| removals.

Comment 4

[Conrad Carlen (not reading bugmail)]

Comment on attachment 144123 [details] [diff] [review]
(Av1b) <createProfileWizard.js>
[Checked in: Comment 8]

r=ccarlen

Comment 5

[jag (Peter Annema)]

Comment on attachment 144123 [details] [diff] [review]
(Av1b) <createProfileWizard.js>
[Checked in: Comment 8]

sr=jag

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 144123 [details] [diff] [review]
(Av1b) <createProfileWizard.js>
[Checked in: Comment 8]


approval1.7=?:
Trivial UI flow fix; no risk.

Comment 7

[chris hofmann]

Comment on attachment 144123 [details] [diff] [review]
(Av1b) <createProfileWizard.js>
[Checked in: Comment 8]

a=chofmann for 1.7

Comment 8

[[e-mail]]

Fix checked in.