237448 - In <am-smtp.js>, "Warning: function onAdvanced does not always return a value"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

{{
Warning: function onAdvanced does not always return a value
Source File: chrome://messenger/content/am-smtp.js
Line: 129
Source Code:
}
}}

Updating:
*(A.To) [e-mail] -> me

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <am-smtp.js>

Big fix,
plus a little cleanup.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) <am-smtp.js>

Av1, without cleanup.

(I moved the modified lines to the left as the existing code permitted.)

Comment 3

[[e-mail]]

Comment on attachment 144128 [details] [diff] [review]
(Av1b) <am-smtp.js>

>       else
>         window.alert(alertMsg);
> 
>-      return false;
>+    return;
>     }
>(I moved the modified lines to the left as the existing code permitted.)
I don't know what you mean here; r=me if you don't change the indent.

>@@ -127,4 +127,3 @@ function onAdvanced(event)
>         onLoad();
>     }
> }
>-
Nit: Unnecessary

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1c) <am-smtp.js> [Checked in: Comment 7]

Av1b, with comment 3 suggestion(s).

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 144972 [details] [diff] [review]
(Av1c) <am-smtp.js>
[Checked in: Comment 7]

Keeping |(Av1b) <am-smtp.js>	 patch		2004-03-17 07:33 PST   
neil.parkwaycc.co.uk: review+|.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 144972 [details] [diff] [review]
(Av1c) <am-smtp.js>
[Checked in: Comment 7]


'approval1.7=?':
Trivial code fix, no risk;
(Trying v1.7 instead of waiting for v1.8a, as v1.7 will become new
long-lived...)

Comment 7

[[e-mail]]

Fix checked in.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 144972 [details] [diff] [review]
(Av1c) <am-smtp.js>
[Checked in: Comment 7]

'approval1.7=?':
Trivial U.I. code cleanup, no risk.
(already on Trunk)

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 144972 [details] [diff] [review]
(Av1c) <am-smtp.js>
[Checked in: Comment 7]

warning cleanups can happen on the trunk. there's not much user value, even if
the risk is low -- and warning cleanups have broken features in the past.