237453 - [FIXr]Less QIing in nsXBLWindowHandler::WalkHandlersInternal

Status: RESOLVED FIXED

(Core :: XBL, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

I see the DOM event QI showing up at several percent of profiles of user
interaction (like keyboard scrolling).  Simply hoisting it out of the loop makes
things a bit better...  The elt change is also to avoid a possibly-unnecessary QI.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 143894 [details] [diff] [review]
Like so

r=me

Though it seems like if this is performance critical code there is a lot more
that can be done.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I don't quite understand the setup here well enough to know what assumptions I
can make (but at a guess, this code is all semi-bogus, like most of XBL).  This
patch was just an easy win.

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 143894 [details] [diff] [review]
Like so

Yeah, this isn't the first time we've solved silly code like this in XBL :-(.

Comment 5

[[e-mail]]

(In reply to comment #2)
>Though it seems like if this is performance critical code there is a lot more
>that can be done.
Such as
if (commandElt)
  commandElt->GetAttribute(NS_LITERAL_STRING("disabled"), disabled);
else
  elt->GetAttr(kNameSpaceID_None, nsHTMLAtoms::disabled, disabled);
perhaps?

Comment 6

[Boris Zbarsky [:bzbarsky]]

hmmm.. maybe.   I'm not sure how big the savings are there...

In any case, this is checked in for 1.8a.