237542 - Firefox should have a Tools > Mail submenu to match new toolbar button

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement, P1)

Description

[Grey Nicholson (they/them)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7b) Gecko/20040314 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7b) Gecko/20040314 Firefox/0.8.0+

Now that Firefox has a Mail toolbar button, there should also be a submenu with
the same functionc.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[David Tenser [:djst]]

Confirming. All toolbar functions should also be accessible from the menu.

Comment 2

[Simon Paquet [:sipaq]]

-> me

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Hook up Tools -> Mail & News on the menubar

Comment 4

[Simon Paquet [:sipaq]]

Comment on attachment 144221 [details] [diff] [review]
Hook up Tools -> Mail & News on the menubar

Ben, can you please review? We should expose every toolbar option in the
menubar.

Comment 5

[Mike Connor [:mconnor]]

I don't necessarily agree, but this is at least a GNOME HIG issue (didn't bother
looking at the other platforms). see
http://developer.gnome.org/projects/gup/hig/1.0/toolbars.html

not a blocker for 0.9, though we should get this in for 1.0beta

blocks bug 233462 (GNOME integration)

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

This should be ifdef XP_WIN, unless you also want to implement shell service on
Mac and Linux :-P

Comment 7

[Simon Paquet [:sipaq]]

Attachment: Patch v2

Comment 8

[Simon Paquet [:sipaq]]

Comment on attachment 151269 [details] [diff] [review]
Patch v2

Mike, could you review this  and land it on branch and trunk. The bug has
blocking+ and Ben seems to like it (see comment 6).

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 151269 [details] [diff] [review]
Patch v2

your CVS tree is old!

please figure out where you want this in the current menu and attach a new
patch.

I'm thinking above/below Web Search, before the divider, but I can be persuaded
if you think there's a better location.

Comment 10

[Simon Paquet [:sipaq]]

Attachment: Patch v3

Oh yeah, sorry for that. I totally forgot...

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 151295 [details] [diff] [review]
Patch v3

that's better.	I'll deal with checkins later this week (and oh what a day that
will be!)

Comment 12

[Mike Connor [:mconnor]]

fixed branch and trunk.  Note that the patch here only applies cleanly to trunk,
the branch has had the locale info reshuffled, but I updated to match and landed.

Comment 13

[Asa Dotzler [:asa]]

And now I can send a page from the File menu and the Tools menu! Just what I
needed. Multiple menu mail accesspoints in my Web browser. Maybe by 1.0 I'll be
able to send email from the Edit menu too!

Oh, I know, let's make an email toolbar. It can have an addressfield, a small
editor widget, and even some html markup buttons. Then we can capture all that
in the browser and just hand off to the user's configured SMTP server directly.
</sarcasm>

Seriously, can we please not have this? Or at least make it conditional on the
user having the Mail menu-button actually on a toolbar? (Please tell me that the
mail button isn't going to be part of the default configuration.) Everyone knows
that Menus are hard. Sub-menus are even harder. Let's not add to the burden by
includiung even more sub-menus that will probably only be interesting to a very
trivial number of users? I'm begging. Please.

Comment 14

[Steffen Wilberg]

> And now I can send a page from the File menu and the Tools menu!
If we keep this in the Tools menu, we should remove "Send Page..." from the File
menu.
And we should change the "Send Link..." label in the Tools menu and the
toolbarbutton to "Send Page..." to match the context menu when not clicking on a
link.

Comment 15

[Bradley Chapman (not reading bugmail, still gone but not forever)]

I'd settle for a way to point Firefox to my Thunderbird installation so that all
these wonderful menu options actually work :-(

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040706 Firefox/0.9.0+
(daihard: P4/SSE2)

Comment 16

[Ryan Polk (Quark)]

switching fixed-aviary1.0 to keyword, for searching purposes.
sorry for bugspam.

Comment 17

[Simon Paquet [:sipaq]]

Verified FIXED Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2)
Gecko/20040827 Firefox/0.9.1+