237611 - title improper If percent of downloading is 0%

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[ZF.Dang]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a) Gecko/20040219

When you are downloading a very large file or the network is quite poor, the 
percent of the downloading progress is 0% and remains 0% for a moment.then the 
title of the progressdialog doesn't update until percent > 0%.
Of course this is not a big problem. but I think it is better to fix it.

Reproducible: Always
Steps to Reproduce:
1.set this.mPercent = -1; in the construction function.
2.
3.

Actual Results:  
title updated properly.

Expected Results:  
title updated properly.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

I'm pretty sure I've seen this bug somehwere already...

Are you saying that doing "this.mPercent = -1;" fixes this bug?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: in patch form

Ah - that does indeed fix the bug. the reason is that setPercent checks if
aPercent != mPercent, and 0 == 0. so init'ing to -1 is the right fix.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 153597 [details] [diff] [review]
in patch form

r=biesi

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 153597 [details] [diff] [review]
in patch form

Sure. sr=bzbarsky.  File a bug on firefox to decide whether this is relevant to
them, please.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsProgressDialog.js;
/cvsroot/mozilla/embedding/components/ui/progressDlg/nsProgressDialog.js,v  <--
 nsProgressDialog.js
new revision: 1.40; previous revision: 1.39
done


No need to file a firefox bug - it doesn't use the progress dialog.