237661 - SVG build with freetype doesn't compile with gcc 3.4

Status: RESOLVED FIXED

(Core :: SVG, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

An SVG build with freetype doesn't compile on gcc 3.4.  Trivial patch coming up,
although I'm a little puzzled by why the code is this way in the first place. 
(I also removed a stray semicolon a few days ago.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Alex Fritze]

Comment on attachment 144053 [details] [diff] [review]
patch

r=afri
I still don't understand why this doesn't compile on gcc3.4, though.
Why do you find the original code puzzling?
The purpose of font_data is simply to avoid having to cast aData later in the
function. 
We only want an alias, not a new physical object on the stack. In the original
version (*&) the compiler shouldn't need to generate any code. Not that it
matters much, but I'm sure gcc is at fault here.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No, this is clearly an error.  The result of a cast is an rvalue.

Comment 4

[Alex Fritze]

(In reply to comment #3)
> No, this is clearly an error.  The result of a cast is an rvalue.
Ah, I see. Thank you for clarifying this. My faith in the world is restored :-)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-03-18 17:36 -0800.