237682 - AIX: Warnings about missing nsACString copy constructor

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Philip K. Warren]

Several errors like the following are showing up in recent builds after the big
string change:

"/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/modules/libpref/src/prefapi.cpp",
line 365.43: 1540-0306 (W) The "private" copy constructor "nsACString(const
self_type &)" cannot be accessed.
"/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/modules/libpref/src/prefapi.cpp",
line 365.43: 1540-0308 (I) The semantics specify that a temporary object must be
constructed.
"/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/modules/libpref/src/prefapi.cpp",
line 365.43: 1540-0309 (I) The temporary is not constructed, but the copy
constructor must be accessible.

This problem looks similar to the one described in Bug 235273 for Sun Workshop
builds.

Comment 1

[Philip K. Warren]

Attachment: Patch v1

Allows creation of the default copy constructor on AIX when using the VisualAge
C++ compiler.

Comment 2

[Darin Fisher]

Comment on attachment 144056 [details] [diff] [review]
Patch v1

change nsTStringTuple back to nsTSubstringTuple.  i checked in that typo fix
while we were talking over IRC.

Comment 3

[Darin Fisher]

Comment on attachment 144056 [details] [diff] [review]
Patch v1

requesting 1.7b approval for an AIX only patch

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 144056 [details] [diff] [review]
Patch v1

a=asa (on behalf of drivers) for checkin to 1.7

Comment 5

[Philip K. Warren]

Fix checked in (with change to nsTSubstringTuple in comment).

Checking in nsTAString.h;
/cvsroot/mozilla/xpcom/string/public/nsTAString.h,v  <--  nsTAString.h
new revision: 1.8; previous revision: 1.7
done