237686 - MVS, OS/390 compatability

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Darin Fisher]

IBM bug report:
> The old Netscape Communicator, MS Internet Explorer, etc. all work without any 
> problems with these servers.  Even the command line FTP clients (and OS/2's 
> FTPPM client) have no problems.  Only Mozilla chokes when I try to access the 
> FTP server on the mainframe.  This is the message I get:
> 
> The FTP Server 215 MVS is the operating system of this server. FTP Server is 
> running on OS/390. is currently unsupported.

dougt wrote:
> Assuming that the this OS / ftpd produces unix style list output, just add a 
> "MVS" to line 1197 of nsFtpConnectionThread.cpp.
> 
> Ideally, we would like to default any unknown server types to UNIX, but in the
> past that caused problems. 


Here's part of the corresponding FTP log:

0[233fb0]: (26194d8)(dwait=0) Writing "SYST^M
"
0[233fb0]: (26194d8) Waiting for control data (0)...
0[233fb0]: (26194d8) reading 82 bytes: "215 MVS is the operating system of this
server. FTP Server is running on OS/390.^M
"
0[233fb0]: (26194d8) FTP_ERROR - Calling StopProcessing 


I think dougt's conclusion is correct.  I'll write up a patch.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Treat both "MVS" and "OS/390" as UNIX.	The server tag is confusing.  It claims
to be both MVS and OS/390, and from what I've read they really are one in the
same.  However, I'm not sure that there aren't cases where only "MVS" appears
but not "OS/390" and vice versa.  So, this patch checks for the presense of
either substring.

Comment 2

[Darin Fisher]

I think we should ideally make the parser more robust (so it does not crash on
bad input) and then default every unknown server type to UNIX.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 144062 [details] [diff] [review]
v1 patch

mServerType matters if it is VMS.  Maybe we should just have the default case
set mServerType to UNIX and drop the dialog.  

I remember this causing regressions, but what we have now is just a bandaide.  
If you want this for 1.7b or 1.7, r=.  if this is for 1.8, I think we should
just removing this cruft and fix the parser.

Comment 4

[Matthias Versen [:Matti]]

FYI: there were crashes in the parser because of using "UNIX" for all unkown
servers. dougt disabled the UNIX fallback and added this dialog (bug 84472).
We have also other open bugs with unkown servers (bug 202730)

Comment 5

[Darin Fisher]

I'd like to extend the bandaide for 1.7

Comment 6

[Darin Fisher]

Comment on attachment 144062 [details] [diff] [review]
v1 patch

marking r=dougt for 1.7 based on comment #3.

Comment 7

[Darin Fisher]

for 1.8 alpha, i'm all for removing this cruft and trying to fix the parser.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 144062 [details] [diff] [review]
v1 patch

sr=bzbarsky

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 144062 [details] [diff] [review]
v1 patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 10

[Darin Fisher]

fixed-on-trunk for 1.7 final

Comment 11

[benc]

is there a public URL for this, I'd like to verify for 1.7