Closed
Bug 237726
Opened 21 years ago
Closed 21 years ago
XUL elements aren't properly registered as DOM3 nodes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.7final
People
(Reporter: neil, Unassigned)
Details
Attachments
(1 file)
657 bytes,
patch
|
jst
:
review+
jst
:
superreview+
chofmann
:
approval1.7+
|
Details | Diff | Splinter Review |
Error: uncaught exception: [Exception... "Illegal operation on WrappedNative
prototype object" nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)"
location: "JS frame :: javascript: top.document.documentElement.textContent ::
<TOP_LEVEL> :: line 1" data: no]
I did a scan of a fair number of elements and attributes and the only attributes
I had problems with were baseURI and textContent of xul elements so I assume the
issue is with the nsIDOM3Node registration.
Reporter | ||
Comment 1•21 years ago
|
||
Reporter | ||
Updated•21 years ago
|
Attachment #144084 -
Flags: superreview?(jst)
Attachment #144084 -
Flags: review?(jst)
Comment 2•21 years ago
|
||
You don't need nsIDOMElementCSSInlineStyle (.style property)?
Comment 3•21 years ago
|
||
Comment on attachment 144084 [details] [diff] [review]
Proposed patch
Good catch! r+sr=jst
Attachment #144084 -
Flags: superreview?(jst)
Attachment #144084 -
Flags: superreview+
Attachment #144084 -
Flags: review?(jst)
Attachment #144084 -
Flags: review+
Reporter | ||
Comment 4•21 years ago
|
||
(In reply to comment #2)
>You don't need nsIDOMElementCSSInlineStyle (.style property)?
No, it's define on nsIDOMXULElement.
Comment 5•21 years ago
|
||
Oh, ugh. Yay XUL dom being different just because. :(
Reporter | ||
Comment 6•21 years ago
|
||
Comment on attachment 144084 [details] [diff] [review]
Proposed patch
Low risk fix for erroneous exception accessing certain xul element attributes.
Attachment #144084 -
Flags: approval1.7b?
Comment 7•21 years ago
|
||
Comment on attachment 144084 [details] [diff] [review]
Proposed patch
a=chofmann for 1.7. wait until later today to make sure tag is cut and beta is
finished before checking in.
Attachment #144084 -
Flags: approval1.7b? → approval1.7+
Reporter | ||
Updated•21 years ago
|
Target Milestone: --- → mozilla1.7final
Reporter | ||
Comment 8•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•