237918 - Installer build throws javascript error on file->import and import dialog does not function

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Richard Klein]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040318 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040318 Firefox/0.8.0+

Error: kIMig has no properties
Source File: chrome://browser/content/migration/migration.js
Line: 6

Previous to this error is a warning:
Warning: reference to undefined property
Components.interfaces.nsIBrowserProfileMigrator
Source File: chrome://browser/content/migration/migration.js
Line: 1

Line 1 is:
const kIMig = Components.interfaces.nsIBrowserProfileMigrator;

Using the component viewer extension, I do not find a component with the
nsIBrowserProfileMigrator interface.

Reproducible: Always
Steps to Reproduce:
1.  Download and install nightly build
2.  If you delete your profile this error is the first thing you hit on startup.
3.  If you use an old profile then start Firefox.
4.  Goto File->Import.
5.  You should now get this error.

Actual Results:  
Import dialog in nonfunctional.

Expected Results:  
Should have a functional import dialog.

Comment 1

[David Hallowell]

*** Bug 238150 has been marked as a duplicate of this bug. ***

Comment 2

[David Hallowell]

I can reproduce this, as you mention this bug only appears on the Win32
installer builds. The file migration.xpt is not installed into the components
directory, whereas in the zip builds it appears.

I'm surprised more people haven't spotted this, I'm guessing the zipped builds
must be more popular than I thought!

You can reproduce this on any platform by deleting the migration.xpt file from
the components directory.

Fix:
Include migration.xpt in the installer builds.

Comment 3

[David Hallowell]

*** Bug 238173 has been marked as a duplicate of this bug. ***

Comment 4

[Hussam Al-Tayeb]

If the bus is caused by a missing file migration.xpt in the installer build,
shouldn't the Component be "installer" ?

Comment 5

[David Hallowell]

Attachment: This should fix the problem

Adding migration.xpt in packages-static should fix the problem, I'm not near a
Windows build environment to test it, but if you do your own builds this should
make it work for you.

(Note: you may still run into bug 236607 where Fx crashes on some platforms
when the migration code is called)

Comment 6

[Bill Mason]

*** Bug 238573 has been marked as a duplicate of this bug. ***

Comment 7

[Hussam Al-Tayeb]

I downloaded the official 20040331 installer nightly. I installed it and 
copied migration.xpt over from the zip version, and the problem went away. So, 
I can confirm that migration.xpt is the missing file.

Comment 8

[Hussam Al-Tayeb]

Is this bug in review?

Comment 9

[Hussam Al-Tayeb]

(In reply to comment #5)
David Hallowell, can you ask for a review on your patch?

Comment 10

[Brian Ryner (not reading)]

Comment on attachment 144605 [details] [diff] [review]
This should fix the problem

r=bryner

Comment 11

[Brian Ryner (not reading)]

checked in (plus the same change for unix/packages-static)

Comment 12

[David Hallowell]

Verified