237928 - No need to build nsBaseClipboard for widget toolkits that don't use it

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Only four toolkits use nsBaseClipboard, but we currently build it for all of them.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Comment 2

[cls]

Comment on attachment 144277 [details] [diff] [review]
Patch

Shouldn't cocoa be using it as well?  rs=cls when you get that figured out.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Ah, right.  I didn't realize that cocoa pulled in the stuff in mac/.  Good
catch.  Change made locally.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 144277 [details] [diff] [review]
Patch

This really could go in beta since its low risk enough, but I'll shoot for
final.

Comment 5

[cls]

(In reply to comment #3)
> Ah, right.  I didn't realize that cocoa pulled in the stuff in mac/.  Good
> catch.  Change made locally.

At a glance, cocoa doesn't pull in the stuff under mac/.  I just thought it odd
that all of the non-X11 toolkits would use nsBaseClipboard except cocoa.  Maybe
pinkerton knows for sure.

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Cls, yeah they do.  See
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/cocoa/Makefile.in&rev=1.24&mark=103-104#103

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

(note that I actually did look when you mentioned that cocoa may need to build
this.)

Comment 8

[cls]

Heh.  Whoops.  I looked too but obviously not as well as you did.  I just lxr'd
for nsBaseClipboard.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 144277 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fix checked in 2004-03-26 00:51 PST.