238052 - In-page tooltips have no border, although gtk-style tooltips do have a border.

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040318 Epiphany/1.3.0

In any gtk+ application, tooltips have a border. However, in the web page,
tooltips (title attribute on a link) do not have a border.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: testcase

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed fix

It is necessary to paint the border on every expose event, not just once
initially.

I've also changed the border width of the tooltip window from 3 to 4, because
that's what gtk+' gtktooltips.c has too.

I've tested the fix on my gtk+-2 build; it should be fine for gtk+-1.2 too but
I don't have a build to test.

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: updated patch, fixes code style issues

Comment 4

[Marco Pesenti Gritti]

checked in on the trunk

Checking in EmbedWindow.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedWindow.cpp,v  <--  EmbedWindow.cpp
new revision: 1.31; previous revision: 1.30
done