238095 - rework pause/resume of net installer

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

I haven't found any user-noticable symptoms of this, but the sequence of events
that happens when hitting pause/resume is:

(pause)
nsHTTPCon::Get calls DownloadCB
DownloadCB flushes events before returning (gtk notices the click on "pause")
DLPause fires off another event loop
(resume)
DLResume ends the event loop and starts PerformInstall()

unfortunately, calling gtk_main_quit in DLResume has no imeadiate effect because
it calls PerformInstall before retruning.

So, pause/resume creates a paused orphan download.

I have a patch for this, but I'm still testing fringe cases.

Comment 1

[Andrew Schultz]

Attachment: patch

the pause event loop now starts in ::Next, and calls PerformInstall from there
if the user resumes.

with this pause/resume/cancel/connection dropped works in normal/auto mode

Comment 2

[Andrew Schultz]

and this doesn't break anything I've noticed, but it prevents me from fixing bug
237792

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 144432 [details] [diff] [review]
patch

r=dveditz

Comment 4

[Andrew Schultz]

fixed