Closed
Bug 238133
Opened 21 years ago
Closed 21 years ago
[nt 3.51] installer suggests invalid directory
Categories
(SeaMonkey :: Installer, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha1
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file, 1 obsolete file)
3.01 KB,
patch
|
dveditz
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
On NT 3.51, Installer suggests "\mozilla.org\Mozilla" as installation directory... (I did not try it out. I don't think I'd have had write access to any root directory on this system)
Assignee | ||
Comment 1•21 years ago
|
||
http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/windows/setup/extra.c#7932 seems to be the function that gets the program files directory
could you possibly make available a reg export? (i don't really have time to play w/ the box)
Assignee | ||
Comment 3•21 years ago
|
||
HKLM\Software\Microsoft\Windows\CurrentVersion has no values directly in it, if that's what you want to know.
Comment 4•21 years ago
|
||
As a side note, the installer does not check for access into several of the install directories, it should default or prompt for each one of them...
Assignee | ||
Comment 5•21 years ago
|
||
have a patch to suggest parent of windows install directory if "program files" reg key is unavailable I won't address comment 4 in this patch.
Priority: -- → P1
Target Milestone: --- → mozilla1.8alpha
Assignee | ||
Comment 7•21 years ago
|
||
let's try without leftover debugging code...
Attachment #144989 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #144992 -
Flags: review?(dveditz+bmo)
Comment 8•21 years ago
|
||
Comment on attachment 144992 [details] [diff] [review] patch v2 The firefox installer will need this change too (Ben forked the code). r=dveditz
Attachment #144992 -
Flags: review?(dveditz) → review+
Assignee | ||
Comment 10•21 years ago
|
||
Comment on attachment 144992 [details] [diff] [review] patch v2 I don't really have the time and interest to patch/build/test randomly forked code, someone else will have to fix firefox
Attachment #144992 -
Flags: superreview?(roc)
Comment on attachment 144992 [details] [diff] [review] patch v2 This should be separated out into a common function (and why isn't code being shared between setup and uninstall?) but I'll let it slide.
Attachment #144992 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 12•21 years ago
|
||
Checking in setup/extra.c; /cvsroot/mozilla/xpinstall/wizard/windows/setup/extra.c,v <-- extra.c new revision: 1.135; previous revision: 1.134 done Checking in uninstall/extra.c; /cvsroot/mozilla/xpinstall/wizard/windows/uninstall/extra.c,v <-- extra.c new revision: 1.30; previous revision: 1.29 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•