238133 - [nt 3.51] installer suggests invalid directory

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

On NT 3.51, Installer suggests "\mozilla.org\Mozilla" as installation directory...

(I did not try it out. I don't think I'd have had write access to any root
directory on this system)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/windows/setup/extra.c#7932
seems to be the function that gets the program files directory

Comment 2

[timeless]

could you possibly make available a reg export? (i don't really have time to 
play w/ the box)

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

HKLM\Software\Microsoft\Windows\CurrentVersion has no values directly in it, if
that's what you want to know.

Comment 4

[[e-mail]]

As a side note, the installer does not check for access into several of the
install directories, it should default or prompt for each one of them...

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

have a patch to suggest parent of windows install directory if "program files"
reg key is unavailable

I won't address comment 4 in this patch.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

let's try without leftover debugging code...

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 144992 [details] [diff] [review]
patch v2

The firefox installer will need this change too (Ben forked the code).
r=dveditz

Comment 9

[timeless]

dveditz: are you sure? firefox explicitly does not support nt3.51

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 144992 [details] [diff] [review]
patch v2

I don't really have the time and interest to patch/build/test randomly forked
code, someone else will have to fix firefox

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 144992 [details] [diff] [review]
patch v2

This should be separated out into a common function (and why isn't code being
shared between setup and uninstall?) but I'll let it slide.

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in setup/extra.c;
/cvsroot/mozilla/xpinstall/wizard/windows/setup/extra.c,v  <--  extra.c
new revision: 1.135; previous revision: 1.134
done
Checking in uninstall/extra.c;
/cvsroot/mozilla/xpinstall/wizard/windows/uninstall/extra.c,v  <--  extra.c
new revision: 1.30; previous revision: 1.29
done