Closed
Bug 238149
Opened 21 years ago
Closed 21 years ago
clean up button removal between dialogs
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
Details
Attachments
(3 files)
|
32.38 KB,
patch
|
dveditz
:
review+
|
Details | Diff | Splinter Review |
|
32.37 KB,
patch
|
bryner
:
superreview+
|
Details | Diff | Splinter Review |
|
32.49 KB,
patch
|
Details | Diff | Splinter Review |
Each dialog in the installer current attempts to figure out what dialog was
active before it (forward or backward), remove the buttons and add its own.
Proper detection is not always easy and any change in the behavior (bug 171317)
can break things.
Instead of being removed by the next dialog, the buttons should be removed by
the dialog that put them there before it shows the next dialog.
|
Assignee | |
Comment 1•21 years ago
|
||
this:
moves button desctruction into each dialog's ::Hide()
removes unused/disabled ::Back and references to them
removes any opportunity for a dialog to know where it came from
helps with bug 236906 since there is no more back button
removes 83 more lines than it adds. :)
Assignee: general → ajschult
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•21 years ago
|
Attachment #144497 -
Flags: review?(dveditz+bmo)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 144497 [details] [diff] [review]
patch
r=dveditz
Attachment #144497 -
Flags: review?(dveditz) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #147025 -
Flags: superreview?(bryner)
|
||
Updated•21 years ago
|
Attachment #147025 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
|
|
Assignee | |
Comment 5•21 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•