238166 - Wording for obsolete themes warning now incorrect

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[David Hallowell]

After the fix for bug 180364 which changed the uninstall button from "Uninstall
%theme_name%" to Uninstall Theme, the wording for the warning that comes up when
you try to select an obsolete theme should be changed:

Currently it's:

You have selected a theme which was designed for an earlier version of %brand%
and is incompatible with your current %brand% version. Please check %brand%
theme sites for an updated version of the theme. You can uninstall this theme by
clicking "Uninstall %theme_name%" button.

where %brand% is usually Mozilla and %theme_name% is the name of the selected theme.

As the button is now simply "Uninstall Theme" this should read:
You have selected a theme which was designed for an earlier version of %brand%
and is incompatible with your current %brand% version. Please check %brand%
theme sites for an updated version of the theme. You can uninstall this theme by
clicking "Uninstall Theme" button.

Simple patch attached.

Comment 1

[David Hallowell]

Attachment: Patch to correct wording on obsolete theme warning

Here's the patch that'll fix the wording on the warning you get if you use an
obsolete theme.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

oops, indeed. thanks for catching this!

assigning to you since you have a patch.

Comment 3

[David Hallowell]

I don't have check in permissions so would you mind checking this in once it
gets r and sr?

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

sure, will do that (well, curently it would also require a=)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should at least the second change wait for 1.8alpha, since we want 1.7b and 1.7
localizations to be compatible?

Comment 6

[David Hallowell]

Comment on attachment 144445 [details] [diff] [review]
Patch to correct wording on obsolete theme warning

dbaron: Good point - I agree we should leave it to 1.8a

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in
xpfe/components/prefwindow/resources/locale/en-US/prefutilities.properties;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/prefutilities.properties,v
 <--  prefutilities.properties
new revision: 1.23; previous revision: 1.22
done
Checking in xpfe/components/prefwindow/resources/content/pref-themes.js;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-themes.js,v 
<--  pref-themes.js
new revision: 1.41; previous revision: 1.40
done


sorry for forgetting about this...