238205 - Attach signature path and choose button do not always disable correctly

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ian Neal]

Using Build ID 2004031910 on WinXP SP1
Steps to reproduce
1. Create at least two mail accounts and make sure attach signature is unchecked
on them all
2. Bring up Mail & Newsgroups Account Settings
3. Note that signature path/choose button are disabled in the default account
4. Select second account and look at signature path/choose button

Expected results
1. signature path/choose button are disabled because the attach signature
checkbox is unchecked

Actual results
1. signature path/choose button are enabled despite the attach signature
checkbox being unchecked.

If you have more than two accounts it is the same for other accounts with
unchecked attach signature checkboxes. If you select outgoing server and then an
accounts main options page then the signature path/choose button are correctly
disabled.

Comment 1

[[e-mail]]

Oh that's weird... even if you were originally on an account with a signature
then when you change to an account without a signature then the path and choose
button are disabled, but if you change to a third account without a signture
then they are reenabled...

Comment 2

[[e-mail]]

OK, so what's happening is this... the locked state is updated by
AccountManager.js which unlocks the controls every time. The disabled state is
then reset by am-main.js, but that hits the broadcaster rather than the controls
themselves. Now (thanks to bz's attribute notification optimization patch?)
since the broadcaster is already disabled it doesn't notifiy the controls, as a
result the controls remain enabled.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[Scott MacGregor]

Comment on attachment 144562 [details] [diff] [review]
Proposed patch

good find Neal.

Comment 5

[[e-mail]]

Comment on attachment 144562 [details] [diff] [review]
Proposed patch

Fairly low-risk patch to fix UI nit.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 144562 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 7

[[e-mail]]

Fix checked in.

Comment 8

[Karen Huang]

Verified as fix on latest 1.7 branch 06-24 builds for all the platforms.
Changing keywords from fixed1.7 to verified1.7.
Leave this bug status "as is" until this bug be verified on trunk again...