238290 - -remote openURL doesn't work without specifying the url protocol

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Calvin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316

Remote control commands no longer work on mozilla 1.7b the same way they used to
with 1.6 and previous versions.

Reproducible: Always
Steps to Reproduce:
1.Launch mozilla and keep it open
2../mozilla -remote 'openURL(www.debian.org,new-tab)'
3../mozilla -remote 'openURL(http://www.debian.org,new-tab)'

Actual Results:  
After step 2.: I get a "Failed to send command" message.
After step 3.: The new tab opens successfully
Same results using "new-window" and "url" only instead of "new-tab".

Expected Results:  
Mozilla should load the url opening a new window or a new tab as it used to do
with previous versions.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Fix

I tracked down what is going on here.  This is a regression from biesi's patch
to bug 183871, but darin is also somewhat at fault for introducing the codepath
to where the regression sparked.

Recently, as a patch to bug 226071, darin added MayOpenURL() which looked for a
scheme on the supplied URL.  If it didn't find it, it just tried to look for a
file: URL.  Biesi's patch which landed in 1.7alpha made it so you can't get a
relative file URL, which is what www.foo.com looks like since there is no
leading path information.

We should be using nsIURIFixup here, which has been specially designed by
rocket scientists to figure out what type of URL it really is.	Once we have
that info, we can proceed as normal.

Comment 2

[[e-mail]]

tested on linux/fc2 from gaim and xchat... appears to work.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 144822 [details] [diff] [review]
Fix

looks good

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 144822 [details] [diff] [review]
Fix

Seeking approval to fix this xremote regression.

Comment 5

[chris hofmann]

Comment on attachment 144822 [details] [diff] [review]
Fix

a=chofmann for 1.7

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fix checked in 2004-03-26 13:44 PST.