238300 - Window menu should conform to Apple Human Interface Guidelines (AAHIG)

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Paul Schreiber]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Firefox's Window menu should conform to Apple Human Interface Guidelines.
Specifically:
* change Minimize Window -> Minimize
* change Zoom Window -> Zoom
* reorder the items so Minimize is first

Reproducible: Always
Steps to Reproduce:
Not applicable.
Actual Results:  
n/a

Expected Results:  
n/a

Comment 1

[Hiro]

Camino is also the same notation as firefox.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7b) Gecko/20040321
Camino/0.7+

Comment 2

[Bruce Davidson]

Confirming that this is wrong on latest builds (Mozilla/5.0 (Macintosh; U; PPC
Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040322 Firefox/0.8.0+). Can't find any
dupes.

See relevant page from HIG:
http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_15_section_4.html#//apple_ref/doc/uid/TP30000356/TPXREF106

Camino suffers the same problem, but this will have to be a seperate bug because
it has different menu code (a .nib).

Comment 3

[HARUNAGA Hirotoshi]

depends on Bug 232919.

Comment 4

[Paul Schreiber]

I didn't even realize Firefox wasn't using a nib. Carbon applications can get a window menu "for free" by 
calling CreateStandardWindowMenu.

OSStatus CreateStandardWindowMenu (
   OptionBits inOptions,
   MenuRef * outMenu
);

See:
http://developer.apple.com/documentation/Carbon/Reference/Window_Manager/wind_mgr_ref/
function_group_21.html#//apple_ref/c/func/CreateStandardWindowMenu

Comment 5

[Paul Schreiber]

HARUNAGA Hirotoshi's comment that this depends on Bug 232919 is incorrect. Addressing the UI is 
separate frm addressing the heuristic.

Comment 6

[Bruce Davidson]

Attachment: Proposed patch

Proposed patch - removes the superfluous word "Window" from the minimize and
zoom options on the MacOS X Windows menu and rearranges them so that Minimize
occurs first, as per the Apple HIG.

Comment 7

[Bruce Davidson]

Comment on attachment 145040 [details] [diff] [review]
Proposed patch

Requesting review

Comment 8

[Bruce Davidson]

Comment on attachment 145040 [details] [diff] [review]
Proposed patch

Requesting super review.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 145040 [details] [diff] [review]
Proposed patch

superreview isn't required for Firefox.  Bruce, if you need someone to check
this in, let me know

Comment 10

[Mike Connor [:mconnor]]

checked in on trunk 2004-04-19 16:28

waiting on clarification on tree rules for 0.9 on the 1.7 branch before
committing anything there.

this isn't really something to block 0.9, maybe the Aquafication release, but
this'll land before 0.9 anyway

Comment 11

[Mike Connor [:mconnor]]

checked in for 0.9 on MOZILLA_1_7_BRANCH at 2004-04-25 12:28

Comment 12

[Hiro]

In Thunderbird, the same problem is still being reproduced.

0.6branch build
version 0.6 (20040501)

Comment 13

[Bruce Davidson]

The Thunderbird problem needs to be raised as a separate bug againt the
Thunderbird product.