Closed Bug 238305 Opened 20 years ago Closed 20 years ago

jsd doesn't build on windows if JS_MARK_DEBUG is set

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

jsd_xpc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) 
struct _iobuf * js_DumpGCHeap" (__imp_?js_DumpGCHeap@@3PAU_iobuf@@A)
jsd3250.dll : fatal error LNK1120: 1 unresolved externals

The linker error clearly indicates that it's looking for a C++ mangled symbol, 
which is wrong since it's a C exported symbol
Attached patch extern wrappingSplinter Review
Attachment #144516 - Flags: review?(rginda)
Comment on attachment 144516 [details] [diff] [review]
extern wrapping

r=rginda
Attachment #144516 - Flags: review?(rginda) → review+
mozilla/js/jsd/jsd_xpc.cpp 	1.65
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: