Closed
Bug 238331
Opened 22 years ago
Closed 21 years ago
Clean Up button tooltip should say "and", not "or"
Categories
(Toolkit :: Downloads API, defect, P5)
Toolkit
Downloads API
Tracking
()
VERIFIED
FIXED
mozilla1.7.4
People
(Reporter: mozilla, Assigned: ali)
Details
(Keywords: polish)
Attachments
(1 file, 1 obsolete file)
|
867 bytes,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7b) Gecko/20040321 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7b) Gecko/20040321 Firefox/0.8.0+
I know it's ridiculously picky, but the tooltip should say "Removes completed,
cancelled *and* failed downloads from the list", as the button removes all three.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
|
Assignee | |
Comment 1•22 years ago
|
||
--> NEW
|
|
Assignee | |
Updated•21 years ago
|
Assignee: bugs → aebrahim
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.0+
Target Milestone: --- → Firefox0.9
|
|
Assignee | |
Comment 2•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #149613 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•21 years ago
|
Target Milestone: Firefox0.9 → Firefox1.0beta
|
|
||
Updated•21 years ago
|
Priority: -- → P5
|
|
Assignee | |
Updated•21 years ago
|
Attachment #149613 -
Flags: review?(mconnor) → review?(bugs)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #149613 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 3•21 years ago
|
||
Attachment #149613 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #152383 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 4•21 years ago
|
||
This blocks RC1, since there is an l10n impact.
Flags: blocking-aviary1.0RC1+
|
||
Comment 5•21 years ago
|
||
If you want to get this in, get it in soon (before the l10n freeze) but this
isn't a blocker and if it misses the l10n freeze, we're not gonna cry. The flags
you set would be appropriate only if this was a bug for which we'd hold the
release and then if it was l10n impactful, we'd need to get it in by RC1.
Flags: blocking-aviary1.0RC1-
Flags: blocking-aviary1.0RC1+
Flags: blocking-aviary1.0-
Flags: blocking-aviary1.0+
|
|
||
Updated•21 years ago
|
Attachment #152383 -
Flags: review?(mconnor) → review+
|
||
Comment 6•21 years ago
|
||
It was actually bitrotten again on the branch due to the locale move. But never
mind. Checked in br & trunk 2004-07-21 00:53/00:54.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Comment 7•18 years ago
|
||
It's not picky (well, it is, but picky is good!), and thanks for fixing this.
Verified on trunk:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007072004 Minefield/3.0a7pre
Status: RESOLVED → VERIFIED
|
||
Updated•17 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•