238349 - SVG-enabled static builds using GDI+ renderer are busted

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Jon Henry]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040323 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040323 Firefox/0.8.0+

I tried building Firefox with SVG support tonight using the GDI+ backend, and
apparantly static builds and SVG don't mix well because we don't link to
gdiplus.lib. Specifically, this combination of mozconfig settings breaks things,
resulting in ~80 unresolved externals at the end of the build process:

ac_add_options --enable-svg
ac_add_options --enable-svg-renderer-gdiplus
ac_add_options --disable-shared
ac_add_options --enable-static

I have a small patch for this.

Reproducible: Always
Steps to Reproduce:
1. Try to create a static build using the SVG GDI+ backend.

Actual Results:  
Linker errors.

Expected Results:  
A working build.

I couldn't make up my mind whether this belongs here or in the SVG component,
but since my patch only touches /config, I figured this was more appropriate.

Comment 1

[Jon Henry]

Attachment: Patch

This three-liner fixed the bustage on Windows XP, and I can't see how it would
pose a problem on other platforms (at least beyond the trouble trying to use
GDI+ on non-Windows platforms would already cause...).

Comment 2

[Jon Henry]

Comment on attachment 144549 [details] [diff] [review]
Patch

Could you please have a look at this when you get the chance?

Comment 3

[Jon Henry]

Comment on attachment 144549 [details] [diff] [review]
Patch

Thank you both for the reviews. Asking for approval1.7, this is a small change
that makes SVG able to compile in static builds.

Whether or not this is granted, I could use some help getting this checked in
at the appropriate time since I have no CVS access.

Comment 4

[Frederic Bezies]

Sorry if it is spamming, but I have to say that I build a firefox with SVG
(statically build) and it rocks ;o)

Thanks for the patch.

Comment 5

[Jon Henry]

If someone could find the time to check this in before 1.7 branches, I'd
appreciate it.

Thanks Frederic. I'm curious, does this patch eliminate the requirement for
having to bundle gdiplus.dll with SVG builds? If so, that would be another bonus
for builders. Maybe you could post a test build on MozillaZine and see if people
on something lower than WinXP can run it.

Comment 6

[Frederic Bezies]

>Thanks Frederic. I'm curious, does this patch eliminate the requirement for

You're welcome.

>having to bundle gdiplus.dll with SVG builds? If so, that would be another bonus
>for builders. Maybe you could post a test build on MozillaZine and see if people
>on something lower than WinXP can run it.

It will be great. I will ask for this asap.

Comment 7

[Frederic Bezies]

Jon : sorry, but file is still needed, even if you're using static build version.

See this thread on mozillazine forums :

http://forums.mozillazine.org/viewtopic.php?p=472096

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in for 1.7final

Checking in config/static-config.mk;
/cvsroot/mozilla/config/static-config.mk,v  <--  static-config.mk
new revision: 3.15; previous revision: 3.14
done