Closed Bug 238464 Opened 22 years ago Closed 21 years ago

Crash setting wallpaper to a broken image

Categories

(Firefox :: General, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: jhenry, Assigned: jhenry)

References

Details

(Keywords: crash, fixed-aviary1.0)

Attachments

(1 file, 1 obsolete file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040323 Firefox/0.8.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040323 Firefox/0.8.0+ If you right-click a broken image icon and select Set as Wallpaper, then click Select in the subsequent dialog, Firefox will crash in nsWindowsShellService::SetDesktopBackground on a null pointer. I have a patch that seems to fix the problem. Maybe this action shouldn't even be enabled on the context menu for non-existant images, but since the other options are (like View Image), I'm just fixing the underlying crash. Reproducible: Always Steps to Reproduce: 1. Try to set your desktop wallpaper to a broken image icon. Actual Results: Firefox will crash. Expected Results: No crash, and no change in the wallpaper image either.
Attached patch Patch (obsolete) — Splinter Review
Easy one-line patch that fixes the crash.
Assignee: firefox → jhenry
Status: NEW → ASSIGNED
Comment on attachment 144631 [details] [diff] [review] Patch Could you please take a look at this when you get the chance, Ben?
Attachment #144631 - Flags: review?(bugs)
WFM. What am I supposed to click in the "Set Wallpaper" dialog after opening it?
After the "set wallpaper" dialog shows up, clicking the "set wallpaper" button in that dialog causes the crash for me. If it would be helpful I can post a stack trace.
Keywords: crash
*** This bug has been marked as a duplicate of 136016 ***
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
Comment on attachment 144631 [details] [diff] [review] Patch > rv = request->GetImage(getter_AddRefs(container)); >- if (!request) return rv; >+ if (!container) return rv; rv happens to be NS_OK. Which means you return the wrong thing. I'm sorry no one looked at this and that I ended up resolving your bug w/ patch as a dupe of another one which just got a patch a moment ago. I only just started triaging wallpaper bugs after i ran into the older report and analyzed the problem.
Attachment #144631 - Flags: review?(bugs) → review-
Correct me if I'm wrong, but this is not a dupe. Yes, it's exactly the same issue, but Firefox forked and then rewrote most of winhooks so the patch from bug 136016 doesn't work. I'll attach a new patch that has the less bogus return value from the other bug.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached patch Better patchSplinter Review
The same fix as the other bug, but applied to the forked Firefox files. I should have caught the bogus return value, that was a stupid oversight.
Attachment #144631 - Attachment is obsolete: true
Attachment #147245 - Flags: review?(bugs)
sorry, i missed that, the code looked the same.
Status: REOPENED → NEW
*** Bug 243080 has been marked as a duplicate of this bug. ***
Comment on attachment 147245 [details] [diff] [review] Better patch moving some easy reviews to mconnor who should be getting to them faster than Ben
Attachment #147245 - Flags: review?(bugs) → review?(mconnor)
Comment on attachment 147245 [details] [diff] [review] Better patch sorry for the latency here, r=mconnor@steelgryphon.com Throwing into the approval-aviary bin.
Attachment #147245 - Flags: review?(mconnor)
Attachment #147245 - Flags: review+
Attachment #147245 - Flags: approval-aviary?
Attachment #147245 - Flags: approval-aviary? → approval-aviary+
I don't mean to be a pain, but I would appreciate it if someone could check this in for me now that it has approval since I do not have CVS access (mconnor, Jesse?). Thanks!
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0PR?
I checked in Jon's fix, trunk and aviary.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago21 years ago
Flags: blocking-aviary1.0PR?
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: