Closed
Bug 238498
Opened 21 years ago
Closed 21 years ago
tree.css in Modern theme uses system colours
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: access, regression)
Attachments
(1 file)
|
1.44 KB,
patch
|
jag+mozilla
:
review+
jag+mozilla
:
superreview+
chofmann
:
approval1.7+
|
Details | Diff | Splinter Review |
Modern theme should not use any system colours at all, but the patch to bug
236973 checked two in. CC'ing the people alleged to have given review.
|
Assignee | |
Comment 1•21 years ago
|
||
My understanding is that alternating colours should not apply to selected rows.
Assignee: varga → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•21 years ago
|
Attachment #144841 -
Flags: review?(caillon)
|
||
Comment 2•21 years ago
|
||
r=varga, but could you optimise classic too?
|
|
||
Comment 3•21 years ago
|
||
Comment on attachment 144841 [details] [diff] [review]
Proposed patch
ok, I was told that classic is tricky and it has its own bug
Attachment #144841 -
Flags: review?(caillon) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #144841 -
Flags: superreview?(jag)
Attachment #144841 -
Flags: review?
Attachment #144841 -
Flags: review+
|
||
Comment 4•21 years ago
|
||
Comment on attachment 144841 [details] [diff] [review]
Proposed patch
sr=jag. Oops, missed this.
Attachment #144841 -
Flags: superreview?(jag)
Attachment #144841 -
Flags: superreview+
Attachment #144841 -
Flags: review?
Attachment #144841 -
Flags: review+
|
|
Assignee | |
Comment 5•21 years ago
|
||
Comment on attachment 144841 [details] [diff] [review]
Proposed patch
Fix for one regression from bug 236973 (assuming you don't simply back that bug
out on the branch).
Attachment #144841 -
Flags: approval1.7?
|
||
Comment 6•21 years ago
|
||
Comment on attachment 144841 [details] [diff] [review]
Proposed patch
a=chofmann for 1.7
Attachment #144841 -
Flags: approval1.7? → approval1.7+
|
|
Assignee | |
Comment 7•21 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•