238518 - verify offline store offset is correct when reading offline message

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[David :Bienvenu]

When an offline store gets out of sync with the .msf file, such that the msg hdr
offset into the offline store in the msg db is wrong, we should detect this when
the user tries to read the message, and clear the offline flag on the msg hdr,
so if the user is online, we'll fall back to fetching the message from the
server, and the next time the user does an offline sync, the message will be
re-downloaded.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

try to read the first five bytes of the offline message - if not "From ", we
know we're corrupted, so clear the flag that says we have the message offline,
and return an error. This will fix both news and imap.

Comment 2

[David :Bienvenu]

Attachment: better fix

in the previous code, the rv was getting shadowed, so we were still returning
success, so we didn't try to load the message from the server again.

Comment 3

[David :Bienvenu]

Comment on attachment 144692 [details] [diff] [review]
better fix

need to remove the decl of nsresult in the code above my change so that we
return the error correctly.

Comment 4

[David :Bienvenu]

Comment on attachment 144692 [details] [diff] [review]
better fix

this is a fairly safe fix that helps repair corruption of offline imap and news
stores.

Comment 5

[chris hofmann]

Comment on attachment 144692 [details] [diff] [review]
better fix

a=chofmann for 1.7

Comment 6

[David :Bienvenu]

fix checked in.