238661 - Move a bookmark folder to itself actually deletes it

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Fen Wu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

In “Manage Bookmarks”, when one moves a folder to itself (it may happen when the
mouse happen to click at wrong place), the folder is removed.

Reproducible: Always
Steps to Reproduce:
1. Go to Bookmarks/Manage Bookmarks on Firefox 0.8 browser
2. Click New Folder toolbar to create a testing folder, e.g. name it “My Test”
3. Select the new created folder and Click Move toolbar
4. Choose the folder itself when it asks to Choose Folder
Notice the folder is actually removed.

Actual Results:  
The folder itself is removed

Expected Results:  
The folder itself should be intact

Comment 1

[Mike Connor [:mconnor]]

Fen, not to discount anything that you guys are doing, but can you please test
against trunk builds from
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/ instead of
a milestone based on code from two months back?

This just gives me an error beep and no action.  Are you testing on a clean
install/profile?

Comment 2

[Oleg Sidletskiy]

reproducable on:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040326
Firefox/0.8.0+
and
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040325

so it's a Mozilla bug too.

Comment 3

[Oleg Sidletskiy]

the Mozillla bug is covered by Bug 204780, but since this is Firefox, can it be
marked as a duplicate of that?

Comment 4

[Mike Connor [:mconnor]]

This is WFM on Linux too.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b)
Gecko/20040327 Firefox/0.8.0+

Oleg it's not a dupe of bug 204780 because the bookmark tree of Firefox is
independend and was splitted from Mozilla a long time before.

Comment 6

[Fen Wu]

(In reply to comment #1)
Mike, I tested on nightly build of 3/29/04 and the problem still exists.

Comment 7

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040417
Firefox/0.8.0+

This bug is still in.

Comment 8

[Mike Connor [:mconnor]]

still works for me

can this be replicated on a clean profile?  I just get an error beep if I try this.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sill confirming with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a)
Gecko/20040416 Firefox/0.8.0+ and fresh profile.

Comment 10

[Ben Fowler]

The dupe is 204780.

This was still in a version I downloaded this morning.

Comment 11

[Richard Corbin]

In reply to comment #10.

This bug isn't a duplicate of Bug 204780. Bookmarks are part of the front-end
(forked between seamonkey/mozilla-suite and firefox) and therefore these are
separate issues.

Comment 12

[Asa Dotzler [:asa]]

I can reproduce this reliably. This requires using the Move dialog, not drag and
drop. Confirmed with 20040721 aviary branch build on winXP. This appears to be
very similar to the above mentioned Seamonkey bug 204780 which has an unreviewed
patch sitting in it. I don't believe the data is actually lost here, though.

Comment 13

[Asa Dotzler [:asa]]

What am I talking about?! Of course it's dataloss. The folder is eaten.

Comment 14

[Asa Dotzler [:asa]]

Vlad, I'm hoping you can help us with this. It's pretty nasty. 

Comment 15

[Tracy Walker [:tracy]]

seeing on Win XP, Mac OSX and linux

Comment 16

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: bookmarks-move-to-self-fix-0.patch

eek, bad bug.. easy fix.

Comment 17

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Patch fix in on aviary. (trunk soon)

Comment 18

[Tracy Walker [:tracy]]

Using Move to move a folder into itself no loger deletes the folder.  It does
nothing as expected.  Seen on 0.9+ branch builds from 0726

Comment 19

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

fixed trunk/branch.

Comment 20

[sairuh (rarely reading bugmail)]

looks good on linux (2004080408-0.9+, fedora 2).

Comment 21

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change