238688 - Cannot subscribe to newsgroups with a + in its name

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Krzysztof Stachlewski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040325
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040325

This happens only to groups with + in their name.
Like comp.lang.c++.moderated for example.
If you click Subscribe or try to check the checkbox, nothing happens.


Reproducible: Always
Steps to Reproduce:

Comment 1

[Stefan Borggraefe]

*** Bug 239042 has been marked as a duplicate of this bug. ***

Comment 2

[Stefan Borggraefe]

Confirming with Linux and a CVS build from yesterday. The JavaScript console
reports the following error when trying to subscribe to a group with a + in its
name by clicking on the corresponding checkmark:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsITreeView.cycleCell]"  nsresult:
"0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame ::
chrome://global/content/bindings/tree.xml :: onxblmousedown :: line 718"  data: no]

When you click on the Subscribe button nothing happens and no error is reported
on the JavaScript console.

I don't think Mozilla 1.7 should be released with this bug, since it prevents
you from using a lot of newsgroups (e.g. all C++ newsgroups).

Comment 3

[Stefan Borggraefe]

Reverting this change made by jshin on February 19th fixes the bug:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mailnews/base/resources/content&command=DIFF_FRAMESET&root=/cvsroot&file=subscribe.js&rev1=1.73&rev2=1.74

Comment 4

[[e-mail]]

Mozilla's handling of unsafe characters in newsgroup names is very broken -
simply searching on "%" in my ISP's news server produces over 25 groups none of
which actually contain a % sign.

Comment 5

[Volker Moell]

See bug #241854: The (more or less the same) quoted error message now appears
now on subscribing on *every* newsgroup.  But the error message has no side
effects, you can work with this newsgroups life before.

Comment 6

[Stefan Borggraefe]

The JavaScript error is probably unrelated to this bug. With the change proposed
in comment 3 you can subscribe to newsgroups with a + in its name again, bug the
JavaScript error still remains. Bug 241854 is now a separate bug about the
JavaScript error.

jshin: Is the change in comment 3 the right fix for this?

Neil: I don't see the issue with the % character you described in comment 4 with
the news servers I use.

Comment 7

[Jan Varga [:janv]]

... or you could just remove |cycler="true"| from subscribedColumn2
because it's handled in SearchOnClick() anyway

Comment 8

[Jan Varga [:janv]]

sorry, that was for bug 241854

Comment 9

[Christine]

Attachment: 238688 bug

Comment 10

[Christine]

Attachment: 238688 bug

Comment 11

[Frank Wein [:mcsmurf]]

Christine: Why did you attach a mozilla.exe here?

Comment 12

[Frank Wein [:mcsmurf]]

jshin: So can we revert your change from
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mailnews/base/resources/content&command=DIFF_FRAMESET&root=/cvsroot&file=subscribe.js&rev1=1.73&rev2=1.74?
I think shiping 1.7 with this is very bad.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

*** Bug 243792 has been marked as a duplicate of this bug. ***

Comment 14

[Scott MacGregor]

re-assigning to jshin since it sounds like his change exposed the problem.

Comment 15

[Jungshik Shin]

I'm on the road (I'm sitting at an Internet cafe) so that I'm afraid I can't
deal with this problem until I get back home. A temporary fix might be to just
revert my change as mentioned in comment #12. 

Comment 16

[[e-mail]]

Of course that would break all non-ascii newsgroup names...

Comment 17

[[e-mail]]

Attachment: Proposed patch

Comment 18

[[e-mail]]

Comment on attachment 149368 [details] [diff] [review]
Proposed patch

So since (for its own nefarious reasons) nsNntpIncomingServer escapes the
string as if it was a URL, we need to as well.

Comment 19

[[e-mail]]

Comment on attachment 149368 [details] [diff] [review]
Proposed patch

Trivial fix for very visible bug.

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 149368 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 21

[[e-mail]]

Fix checked in.

Comment 22

[(not reading, please use [e-mail] instead)]

> Of course that would break all non-ascii newsgroup names

I'm glad you remembered about that.  thanks for remembering not to break that.

Comment 23

[R.K.Aa.]

*** Bug 244977 has been marked as a duplicate of this bug. ***

Comment 24

[Karen Huang]

Reporter Krzysztof, [e-mail]:
Can one of you help for verifying this bug since you have newsgroups with a + 
in its name for your news server? 

Please changing Keywords from fixed1.7 to verified1.7 if you verified on the 
latest 1.7 builds:

http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/latest-1.7/

Thanks.

Comment 25

[Krzysztof Stachlewski]

It works with my news server now. Thanks!

Comment 26

[Jungshik Shin]

*** Bug 243467 has been marked as a duplicate of this bug. ***

Comment 27

[Mike Cowperthwaite]

*** Bug 242771 has been marked as a duplicate of this bug. ***