Closed Bug 238704 Opened 21 years ago Closed 21 years ago

RFE: Need sample plugin for plugin printing

Categories

(Core Graveyard :: Plug-ins, enhancement, P4)

All
Linux
enhancement

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7beta

People

(Reporter: roland.mainz, Assigned: roland.mainz)

References

()

Details

Attachments

(1 file, 1 obsolete file)

RFE: Need sample plugin for plugin printing (this is a spinn-off from bug 234470 comment #32) ...
Taking myself...
Assignee: peterlubczynski-bugs → roland.mainz
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → mozilla1.7beta
Someone with CVS access needs to create mozilla/modules/plugin/samples/unixprinting/ before I can make a diff...
ToDo: - The print plugin still depends on GTK+ - The license template is not correct - The code needs minor cleanup
Attachment #144794 - Attachment is obsolete: true
Blocks: 234470
Comment on attachment 144802 [details] [diff] [review] Patch for 2004-03-26-trunk Requesting r= ...
Attachment #144802 - Flags: superreview?(Henry.Jia)
Attachment #144802 - Flags: review?(kyle.yuan)
Comment on attachment 144802 [details] [diff] [review] Patch for 2004-03-26-trunk I don't think I can handle this, over to Pete.
Attachment #144802 - Flags: review?(kyle.yuan) → review?(pete.zha)
Attachment #144802 - Flags: review?(pete.zha) → review?(dantifer.dang)
Attachment #144802 - Flags: review?(dantifer.dang) → review+
Comment on attachment 144802 [details] [diff] [review] Patch for 2004-03-26-trunk Seems ok for me. => jst for double check since I'm not quite familiar in this area.
Attachment #144802 - Flags: superreview?(Henry.Jia) → superreview?(jst)
Comment on attachment 144802 [details] [diff] [review] Patch for 2004-03-26-trunk sr=jst
Attachment #144802 - Flags: superreview?(jst) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
What coordinate system is that plugin assuming and why? I don't see that documented anywhere in that patch (after all the discussion in bug 234470... <sigh>).
(In reply to comment #10) > What coordinate system is that plugin assuming and why? I don't see that > documented anywhere in that patch (after all the discussion in bug 234470... > <sigh>). coordinate system for plugin is PS's standard user sapce. That is: right x increases, up y increases. lower-left point's coordinate is not set. In fact the only thing plugin should know is the rectangle's width & height. Plugin can take lower-left-point as whatever it likes only if it gives the right boundbox. for example, plugin gets rectangle's width=200, height=300. It takes lower-left-point as (0,0), then draw a box (0,0,200,300), gives boundbox (0,0,200,300). It can also take lower-left-point as (100,100), then draw a box (100,100,300,400), gives boundbox (100,100,300,400). mozilla is responsible for the rest job and it can. That is EPSF's advantage.
Right. The point is, don't tell _me_ that. Put that in the sample plugin, in nice comments, so that people who try to use it as a model for writing their own plugins (that's the point, right?) will know exactly what they're working with.
Good suggestion. And I think it is also necessary to update "Plugin API Reference".
If you can do that, that would be great.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: