238807 - Compilation error in txXPathTreeWalker.h when building txXMLParser

Status: RESOLVED FIXED

(Core :: XSLT, defect, P1)

Description

[Kishan Thomas]

User-Agent:       Mozilla/5.0 (X11; U; HP-UX 9000/785; en-US; rv:1.4) Gecko/20031022
Build Identifier: Mozilla/5.0 (X11; U; HP-UX ia64; en-US; rv:1.6) Gecko/20040227

Encountered the following compilation error when 
building Mozilla 1.6 on HP-UX platform with aCC compiler.

code
----

http://lxr.mozilla.org/mozilla/source/extensions/transformiix/source/xpath/txXPathTreeWalker.h

    73  class txXPathTreeWalker
    74  {
    75  public:
    76      explicit txXPathTreeWalker(const txXPathTreeWalker& aOther);
    77      explicit txXPathTreeWalker(const txXPathNode& aNode);
    78      ~txXPathTreeWalker();

compile
-------

http://lxr.mozilla.org/seamonkey/source/extensions/transformiix/source/xml/parser/txXMLParser.cpp

aCC -ext +DA1.1 +DS2.0 -o txXMLParser.o -c txXMLParser.cpp

error
-----

Error 513: "./../../xpath/txXPathTreeWalker.h", line 76 # 'explicit' may be used
only for convertin
g constructors.
        explicit txXPathTreeWalker(const txXPathTreeWalker& aOther);
                 ^^^^^^^^^^^^^^^^^

compiler
-------

aCC: HP ANSI C++ B3910B A.03.25

fix
--

The compiler error goes away on removing the 'explicit' 

    73  class txXPathTreeWalker
    74  {
    75  public:
    76      txXPathTreeWalker(const txXPathTreeWalker& aOther);
    77      txXPathTreeWalker(const txXPathNode& aNode);
    78      ~txXPathTreeWalker();





Reproducible: Always
Steps to Reproduce:
On HP-UX  platform using aCC compilers

1.  Build extensions/transformiix/source/xml/parser
2.  aCC -ext +DA1.1 +DS2.0 -o txXMLParser.o -c txXMLParser.cpp


Actual Results:  
Error 513: "./../../xpath/txXPathTreeWalker.h", line 76 # 'explicit' may be used
only for convertin
g constructors.
        explicit txXPathTreeWalker(const txXPathTreeWalker& aOther);

Expected Results:  
Expected no compilation error.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, the compiler looks correct.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We still want to keep the explicit for signature taking an txXPathNode though.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Hmm.. another interesting question is if the copy-ctor is used at all? IIRC msvc
or gcc does fail when you try to actually call a copy-ctor that is marked as
explicit.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It would be good to check in the obvious one line patch so that it compiles, though.

Comment 5

[Peter Van der Beken [:peterv]]

The copy constructor is used (for example by txLocPathPattern::matches).

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 147449 [details] [diff] [review]
v1

sr=jst

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 147449 [details] [diff] [review]
v1

Simple fix to make transformiix compile on HP-UX with the aCC compiler. No
risk.

Comment 9

[Peter Van der Beken [:peterv]]

Checked in on trunk and branch (forgot to mention a=dbaron in checkin comment :-/).