238913 - Wrong name for attachment dragged from one message to compose attachment panel

Status: VERIFIED FIXED

(MailNews Core :: Attachments, defect)

Description

[Mike Cowperthwaite]

This is a followup to bug 233740; both bugs were regressions introduced by the 
feature implemented for bug 83803.

When dragging an attachment from a message to the compose window, it is shown in 
the panel as "Attached Message Part".  This apparently becomes the permanent 
name for the attachment -- that's how it shows up in the received mail as well.
(This bug does not manifest in Thunderbird, just Seamonkey.)

To reproduce:
1) Display a message available with an attachment (standalone or preview)
2) Open a compose window
3) Drag the attachment from the displayed message's attachment panel to the 
compose window's attachment panel.
4) Send the message

Actual results:
after (3), attachment in compose window shown as "Attached Message Part"
after (4), attachment in displayed message (in Sent, or as received) is shown as 
"Attached Message Part".

Expected results:
Original filename persists across drag.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040324

xref bug 209629.

Comment 1

[Scott MacGregor]

Attachment: the fix

the fix is to give the moz-url flavor precedence. I can still drag to the
desktop and it ends up being a file without a problem.

There is still one issue I need to fix here. It looks like the drag and drop
toolkit code is calling the file flavor object which causes us to take the drag

data and save it to a temp file even though the drop ends up ignoring the
moz-promise-file flavor. Hence, I can see a little progress window dialog popup

when I drag an attachment to the compose window.

I think the drag and drop toolkit code needs modified to only call the
moz-promise-file flavor provider if and only if the drop target cares about
that flavor type. But that can be investigated separately from this bug.

Comment 2

[chris hofmann]

Comment on attachment 145354 [details] [diff] [review]
the fix

a=chofmann for 1.7

Comment 3

[Scott MacGregor]

fixed for seamonkey and thunderbird

Comment 4

[Mike Cowperthwaite]

Scott, am I correct that the patch posted here is the exact same patch you 
posted for bug 238846?

Comment 5

[Mike Cowperthwaite]

Verified fixed in
  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040406