239181 - IMAP STATUS command should not be used on selected mailbox

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Ere Maijala (slow)]

Running trunk build 2004032208 on WinXP. The server is running uw-imapd.

I was logging my IMAP traffic and noticed that Mozilla tries to query status of
a selected folder. In a few minutes I got quite a few lines like this:
1256[248d208]: 3475890:atp.fi:S-Mail/SPAM:CreateNewLineFromSocket: * NO CLIENT
BUG DETECTED: STATUS on selected mailbox: Mail/SPAM

According to the log file, the connection had Mail/SPAM already selected and it
had been IDLE before that (previously issued commands were IDLE and DONE). 

RFC 3501 states, that "the STATUS command SHOULD NOT be used on the currently
selected mailbox".

Setting severity to major as this could cause severe problems with some servers.

Comment 1

[David :Bienvenu]

Attachment: use NOOP instead of STATUS if we're selected

Comment 2

[David :Bienvenu]

Comment on attachment 149082 [details] [diff] [review]
use NOOP instead of STATUS if we're selected

I think this will do the right thing when new messages come in, but it would be
great if you could try it out, Ere. I'm pretty sure we won't be doing STATUS on
selected folders, and * think we'll update the counts for unread and recent
correctly.

Comment 3

[David :Bienvenu]

Attachment: whoops, correct fix.

Comment 4

[David :Bienvenu]

Comment on attachment 149102 [details] [diff] [review]
whoops, correct fix.

that was a patch from a different tree, for a different bug...

Comment 5

[David :Bienvenu]

fixed on trunk.

Comment 6

[David :Bienvenu]

re-opening, because I'm going to back out this fix. It caused the regression
http://bugzilla.mozilla.org/show_bug.cgi?id=245044?

Comment 7

[David :Bienvenu]

fixed by fix in bug 245769