239240 - Choosing Unblock Images from this Server in context menu whitelists site instead of removing permission

Status: RESOLVED FIXED

(Core :: Graphics: Image Blocking, defect, P2)

Description

[Mike Connor [:mconnor]]

I fixed this a while back in Tools->Cookie Manager and Tools->Image Manager, but
not in the context menu.  Yay morse!

Comment 1

[Mike Connor [:mconnor]]

in 1.8a I might implement something in the overlay to give the option of
whitelisting sites for images if images are turned off by default.  It doesn't
make sense to give options to block images from sites if you're already blocking
images from everyone.

Comment 2

[Mike Connor [:mconnor]]

Attachment: use .remove() instead of .add() (also remove obsolete comments)

missed a couple references to the imageblocker.enabled pref that was removed a
while back, which is the extra lines here.

Comment 3

[[e-mail]]

Comment on attachment 145146 [details] [diff] [review]
use .remove() instead of .add() (also remove obsolete comments)

indeed. r=me

Comment 4

[[e-mail]]

simple and low-risk enough for 1.7, if time permits.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 145146 [details] [diff] [review]
use .remove() instead of .add() (also remove obsolete comments)

a=asa (on behalf of drivers) for checkin to 1.7

Comment 6

[Mike Connor [:mconnor]]

checked in 2004-04-07 16:23