239298 - compile warnings with gcc

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Henrik Gemal]

when compiling with gcc in windows I see:

d:/mozilla/mozilla/xpcom/io/nsLocalFileWin.cpp: In member function `virtual
   nsresult nsLocalFile::Remove(int)':
d:/mozilla/mozilla/xpcom/io/nsLocalFileWin.cpp:1438: warning: comparison
   between signed and unsigned integer expressions
d:/mozilla/mozilla/xpcom/io/nsLocalFileWin.cpp: In member function `virtual
   nsresult nsLocalFile::GetPermissions(PRUint32*)':
d:/mozilla/mozilla/xpcom/io/nsLocalFileWin.cpp:1561: warning: unused variable `
   const char*filePath'
d:/mozilla/mozilla/xpcom/io/nsLocalFileWin.cpp: In member function `virtual
   nsresult nsLocalFile::Launch()':
d:/mozilla/mozilla/xpcom/io/nsLocalFileWin.cpp:2282: warning: unused variable `
   nsresult rv'
../../dist/include/xpcom/nsCOMPtr.h: At top level:
d:/mozilla/mozilla/xpcom/io/nsLocalFileWin.cpp:230: warning: `void
   myLL_II2L(int, int, PRInt64*)' defined but not used

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

I tried to not change the logic esp. of GetPermissions...

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 145203 [details] [diff] [review]
patch

please remove the other myLL_II2L in the OS2 version.  

I think i like this syntax better:

+    if (rv == (nsresult)-1)

with that, r=dougt

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, with those changes made

Checking in nsLocalFileOS2.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileOS2.cpp,v  <--  nsLocalFileOS2.cpp
new revision: 1.75; previous revision: 1.74
done
Checking in nsLocalFileWin.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileWin.cpp,v  <--  nsLocalFileWin.cpp
new revision: 1.116; previous revision: 1.115
done