Closed
Bug 239391
Opened 21 years ago
Closed 21 years ago
in NativeReplaceFile condition for rename failure is reversed
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(1 file)
|
548 bytes,
patch
|
pkwarren
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
found by cavin song
RENAME(2) Linux Programmer's Manual RENAME(2)
RETURN VALUE
On success, zero is returned. On error, -1 is returned,
and errno is set appropriately.
72 if (!rename(replacementFile, doomedFile))
73 return TRY_LATER; // this shouldn't happen
so, if rename returns success, !rename is true and it returns try later.
Status: NEW → ASSIGNED
Attachment #145293 -
Flags: review?(pkw)
|
||
Updated•21 years ago
|
Attachment #145293 -
Flags: review?(pkw) → review+
Attachment #145293 -
Flags: superreview?(dveditz+bmo)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 145293 [details] [diff] [review]
reverse check for rename...
>- if (!rename(replacementFile, doomedFile))
>+ if (rename(replacementFile, doomedFile))
if (rename() != 0) would be in keeping with this file's style (see the unlinks)
but sr=dveditz either way.
Attachment #145293 -
Flags: superreview?(dveditz+bmo) → superreview+
mozilla/xpinstall/cleanup/InstallCleanupUnix.cpp 1.10
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•