239644 - FreeBSD build error in nsHostResolver

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Darin Fisher]

From n.p.m.unix:
news://news.mozilla.org:119/[e-mail]

> I'm trying to build mozilla 1.7b (but I have exprienced same error
> with 1.6 and Firebox 0.8) on FreeBSD 5.2.1 for x86.
> 
> Any suggestion would be appreciated.
> 
> $ cc -v
> Using built-in specs.
> Configured with: FreeBSD/i386 system compiler
> Thread model: posix
> gcc version 3.3.3 [FreeBSD] 20031106
> 
> $ c++ -Wall -I/usr/local/include -L/usr/local/lib -o nsDNSService2.o
> -c -DOSTY>
> In file included from nsDNSService2.h:40,
>                  from nsDNSService2.cpp:37:
> nsHostResolver.h:87: error: syntax error before `*' token
> nsHostResolver.h: In member function `PRBool nsHostRecord::HasResult()
> const':
> nsHostResolver.h:92: error: syntax error before `;' token
> nsHostResolver.h: At global scope:
> nsHostResolver.h:186: error: syntax error before `*' token
> nsDNSService2.cpp: In member function `virtual nsresult
>    nsDNSRecord::GetCanonicalName(nsACString&)':
> nsDNSService2.cpp:90: error: invalid use of `struct addrinfo'
> nsDNSService2.cpp:91: error: invalid use of `struct addrinfo'
> nsDNSService2.cpp:91: error: `PR_GetCanonNameFromAddrInfo' undeclared
> (first
>    use this function)
> nsDNSService2.cpp:91: error: (Each undeclared identifier is reported
> only once
>    for each function it appears in.)
> nsDNSService2.cpp: In member function `virtual nsresult
>    nsDNSRecord::GetNextAddr(short unsigned int, PRNetAddr*)':
> nsDNSService2.cpp:107: error: invalid use of `struct addrinfo'
> nsDNSService2.cpp:108: error: invalid use of `struct addrinfo'
> nsDNSService2.cpp:108: error: `PR_EnumerateAddrInfo' undeclared (first
> use this
>    function)
> nsDNSService2.cpp: In member function `PRUint16
>    nsDNSService::GetAFForLookup(const nsACString&)':
> nsDNSService2.cpp:516: error: `PR_AF_UNSPEC' undeclared (first use
> this
>    function)

It looks like naming a variable "addrinfo" is conflicting with the definition of
"struct addrinfo" pulled in from the system headers.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

Comment on attachment 146204 [details] [diff] [review]
v1 patch

this patch just does s/addrinfo/addr_info/ on netwerk/dns/src

Comment 3

[Darin Fisher]

fixed-on-trunk

Comment 4

[Darin Fisher]

marking FIXED

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 146204 [details] [diff] [review]
v1 patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 6

[Darin Fisher]

fixed1.7