239843 - url logging crash when nsImapProtocol not yet created

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Daniel Veditz [:dveditz]]

Some 3rd party extensions can use nsImapIncomingServer before nsImapProtocol is
contructed. The fix for bug 221023 added a static nsImapProtocol::LogImapUrl
which can be called before the IMAP PR_LogModuleInfo is created by the
nsImapProtocol contructor.

Comment 1

[David :Bienvenu]

I'll look into it. What 3rd party extension would this be? You can tell me
privately if you want...

Comment 2

[Daniel Veditz [:dveditz]]

Attachment: simple fix

This patch solves the problem

Comment 3

[Scott MacGregor]

Comment on attachment 145577 [details] [diff] [review]
simple fix

It's interesting that this method can get called before the constructor for
nsImapProtocol which initializes the IMAP log modules:

http://lxr.mozilla.org/mozilla/source/mailnews/imap/src/nsImapProtocol.cpp#447

What other mozilla stuff is on the stack trace Dan?

Oh I see your comment in the beginning of the bug. It's a static method.

Comment 4

[David :Bienvenu]

Comment on attachment 145577 [details] [diff] [review]
simple fix

yes, that's fine.

Comment 5

[David :Bienvenu]

It's still odd that it gets called before any nsImapProtocol object is created
so I am curious about the stack trace.

Comment 6

[chris hofmann]

Comment on attachment 145577 [details] [diff] [review]
simple fix

a=chofmann for 1.7

Comment 7

[Daniel Veditz [:dveditz]]

Checking in nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.550; previous revision: 1.549