Closed Bug 239902 Opened 21 years ago Closed 21 years ago

cleaning up imap inbox on exit with inbox configured for offline use leaves temp files

Categories

(MailNews Core :: Backend, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

Attachments

(1 file)

If you set up your imap inbox for offline use, and configure the server to expunge the inbox on exit, we'll leave temp files around because we try to compact the offline inbox store on exit, but exit before the offline store compact is finished. This causes us to leave temp files around in the imap directory. The temporary fix is to not compact the offline store when the msg window is null, and make it so the msg window is only null when doing a compact at exit.
Attached patch proposed fixSplinter Review
the first part of the fix is to make sure m_window gets set in nsMsgFolderCompactState so that when we do a compact all, the compact call for folders after the first call get the msg window passed in. The second part is to not compact the offline store when we don't have a msg window. When we re-architect the shutdown code, this will all get cleaned up.
Comment on attachment 145631 [details] [diff] [review] proposed fix I will try to get this into 1.7
Attachment #145631 - Flags: superreview?(mscott)
Attachment #145631 - Flags: superreview?(mscott) → superreview+
Attachment #145631 - Flags: approval1.7?
Comment on attachment 145631 [details] [diff] [review] proposed fix a=chofmann for 1.6
Attachment #145631 - Flags: approval1.7? → approval1.7+
er, 1.7
fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: