Closed
Bug 239953
Opened 20 years ago
Closed 20 years ago
Remove duplicated code in nsContentUtils
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha1
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
14.51 KB,
patch
|
sicking
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
nsContentUtils duplicates some code in nsJSUtils, and now that the two files live in the same library, the duplicated code can be removed. Patch coming up.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #145654 -
Flags: superreview?(peterv)
Attachment #145654 -
Flags: review?(bugmail)
Comment on attachment 145654 [details] [diff] [review] Remove duplicated code. assuming it compiles, r=me
Attachment #145654 -
Flags: review?(bugmail) → review+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 145654 [details] [diff] [review] Remove duplicated code. I'm assuming the differences between nsJSUtils::GetStaticScriptGlobal and nsContentUtils::GetStaticScriptGlobal don't matter.
Attachment #145654 -
Flags: superreview?(peterv) → superreview+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Shouldn't matter at all, no.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.8alpha
|
|
Assignee | |
Comment 5•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•