240092 - Application name in View Source titlebar differs from application

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bill Mason]

In the titlebar of a View Source window, the application name is simply
"Firefox" instead of "Mozilla Firefox".

Comment 1

[Bill Mason]

Forgot to note that I'm seeing this in the 20040406 build.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Changes titlemodifier entity to &brandFullName;

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 145750 [details] [diff] [review]
Changes titlemodifier entity to &brandFullName;

Going by <http://forums.mozillazine.org/viewtopic.php?t=51312> it appears the
titlemodifier attribute in toolkit/components/viewsource/content/viewSource.xul
is the culprit.  The attribute is the entity &mainWindow.titlemodifier; which
is changed in the patch.

This is an easy, simple, one-liner patch; could it perhaps get in for Firefox
0.9?

Comment 4

[Jeff Walden [:Waldo]]

I've managed to get access to a computer for a sec, so nominating a few polish
bugs for Firefox 1.0...

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Corrects an idiotic goof

I didn't realize "Firefox" was specified through two different attributes in
viewSource.xul (and thus two different entities) when I made the older patch. 
This patch makes the correct extra change to the entity for the window title
(shows up when no document is viewed, aka view-source:).  I'm not quite sure if
another review is required as the extra change just duplicates the initial one
at another point in the file.

Comment 6

[R.J. Keller]

Fix checked in on the aviary branch and on the trunk.

Comment 7

[Mike Connor [:mconnor]]

good catch, although I don't think anyone really opens view source without a
page loaded :)

Comment 8

[Bill Mason]

v trunk 20040523 PC/WinXP