Closed
Bug 240122
Opened 21 years ago
Closed 21 years ago
document.body setter cleanup, and accesskey code cleanup.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha1
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
7.87 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
nsHTMLDocument::SetBody() is bloaty, slow, and broken. And
nsGenericHTMLElement::RegUnRegAccessKey() returns nsresult for no reason. Patch
coming up.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Assignee: general → jst
Target Milestone: --- → mozilla1.8alpha
|
|
Assignee | |
Updated•21 years ago
|
Attachment #145769 -
Flags: superreview?(bzbarsky)
Attachment #145769 -
Flags: review?(bzbarsky)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 145769 [details] [diff] [review]
Clean up nsHTMLDocument::SetBody() and deCOMtaminate nsGenericHTMLElement::RegUnRegAccessKey().
Looks fine. r+sr=bzbarsky.
Attachment #145769 -
Flags: superreview?(bzbarsky)
Attachment #145769 -
Flags: superreview+
Attachment #145769 -
Flags: review?(bzbarsky)
Attachment #145769 -
Flags: review+
|
||
Comment 3•21 years ago
|
||
Perhaps you can remove this comment, since it seems you fixed it.
// Hmm, this is wrong, and not XHTML cool. The body can be a
// frameset too!
// The body element must be of type nsIDOMHTMLBodyElement.
|
|
Assignee | |
Comment 4•21 years ago
|
||
Hmm, yeah, meant to do that... Done locally, I'll try to get that in when this
lands...
|
|
Assignee | |
Comment 5•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•