240122 - document.body setter cleanup, and accesskey code cleanup.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

nsHTMLDocument::SetBody() is bloaty, slow, and broken. And
nsGenericHTMLElement::RegUnRegAccessKey() returns nsresult for no reason. Patch
coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Clean up nsHTMLDocument::SetBody() and deCOMtaminate nsGenericHTMLElement::RegUnRegAccessKey().

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 145769 [details] [diff] [review]
Clean up nsHTMLDocument::SetBody() and deCOMtaminate nsGenericHTMLElement::RegUnRegAccessKey().

Looks fine.  r+sr=bzbarsky.

Comment 3

[Fabian Guisset]

Perhaps you can remove this comment, since it seems you fixed it.
// Hmm, this is wrong, and not XHTML cool. The body can be a
// frameset too!
// The body element must be of type nsIDOMHTMLBodyElement.

Comment 4

[Johnny Stenback (:jst)]

Hmm, yeah, meant to do that... Done locally, I'll try to get that in when this
lands...

Comment 5

[Johnny Stenback (:jst)]

Fix checked in.