Closed Bug 240240 Opened 20 years ago Closed 20 years ago

[FIXr]Possible double-delete of style set

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.7final

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: crash, fixed1.7)

Attachments

(1 file)

Patch
3.12 KB, patch
bryner
: review+
bryner
: superreview+
dbaron
: approval1.7+
Details | Diff | Splinter Review 
If the presshell's Init() fails after it sets mStyleSet, it will delete the
style set, and so will the document viewer.

We really need to clean up this code.  :(
Attached patch Patch — — Splinter Review 
We need mStyleSet to be set for some of the initialization to work right, so we
can't just set it up at the end.  :(
Attachment #145867 - Flags: superreview?(bryner)
Attachment #145867 - Flags: review?(bryner)
Priority: -- → P1
Summary: Possible double-delete of style set → [FIX]Possible double-delete of style set
Target Milestone: --- → mozilla1.7final
Severity: normal → critical
Keywords: crash
Attachment #145867 - Flags: superreview?(bryner)
Attachment #145867 - Flags: superreview+
Attachment #145867 - Flags: review?(bryner)
Attachment #145867 - Flags: review+
Comment on attachment 145867 [details] [diff] [review]
Patch

Could this be approved for 1.7?  Fixes a possible double-delete crash that I
ran into...
Attachment #145867 - Flags: approval1.7?
Summary: [FIX]Possible double-delete of style set → [FIXr]Possible double-delete of style set
Checked in for 1.8a.  Leaving open pending 1.7 checkin.
Checked in to 1.7 branch.
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed1.7
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: