Closed
Bug 240309
Opened 21 years ago
Closed 21 years ago
Remove \n from JavaScript [error:\n|warning:\n]
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: bc, Assigned: jst)
References
()
Details
Attachments
(1 file)
|
2.19 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
The current reporting of JavaScript errors in DEBUG builds inserts a newline
after the JavaScript [error|warning]:. This means that it is not possible to do
a grep on a log file and extract the JavaScript error and warning messages.
It would be very nice if we could remove the \n in line 264 and 266 in
nsJSEnvironment.cpp and get this on 1.7's train.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #145942 -
Flags: superreview?(bzbarsky)
Attachment #145942 -
Flags: review?(bzbarsky)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 145942 [details] [diff] [review]
Remove extra '\n's and clean this code up a bit (debug only).
r+sr=bzbarsky
Attachment #145942 -
Flags: superreview?(bzbarsky)
Attachment #145942 -
Flags: superreview+
Attachment #145942 -
Flags: review?(bzbarsky)
Attachment #145942 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•