Closed Bug 240334 Opened 20 years ago Closed 20 years ago

Make NR_RegOpen use const char*

Categories

(Core Graveyard :: Profile: Migration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8alpha1

People

(Reporter: benjamin, Assigned: benjamin)

Details

(Whiteboard: fixed on AVIARY_1_0_20040515_BRANCH)

Attachments

(1 file)

I've been working on some profile-migration stuff for firefox that uses libreg
directly, instead of using the XPCOM wrapper goop, and I found that NR_RegOpen
uses char* instead of const char*. Since this change doesn't affect the ABI of
libreg, I would like to fix it.
Attachment #145955 - Flags: superreview?(dveditz+bmo)
Attachment #145955 - Flags: review?(dveditz+bmo)
I vaguely recall doing this once, and that there was some reason I didn't check
it in. What systems have you compiled this on? (or rather, which ones not?) Did
you build the windows install?

I'll sleep on it to see if something comes to mind before I review. On the
surface looks good, except for the vague worry.
Comment on attachment 145955 [details] [diff] [review]
make NR_RegOpen use const char*

r/sr=dveditz
Attachment #145955 - Flags: superreview?(dveditz)
Attachment #145955 - Flags: superreview+
Attachment #145955 - Flags: review?(dveditz)
Attachment #145955 - Flags: review+
fixed-on-trunk
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha
Comment on attachment 145955 [details] [diff] [review]
make NR_RegOpen use const char*

Need this for firefox profile-import stuff on the 1.7 branch.
Attachment #145955 - Flags: approval1.7?
Comment on attachment 145955 [details] [diff] [review]
make NR_RegOpen use const char*

We made a firefox branch, don't need approvals.
Attachment #145955 - Flags: approval1.7?
Whiteboard: fixed on AVIARY_1_0_20040515_BRANCH
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: