240334 - Make NR_RegOpen use const char*

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Migration, defect)

Description

[Benjamin Smedberg]

I've been working on some profile-migration stuff for firefox that uses libreg
directly, instead of using the XPCOM wrapper goop, and I found that NR_RegOpen
uses char* instead of const char*. Since this change doesn't affect the ABI of
libreg, I would like to fix it.

Comment 1

[Benjamin Smedberg]

Attachment: make NR_RegOpen use const char*

Comment 2

[Daniel Veditz [:dveditz]]

I vaguely recall doing this once, and that there was some reason I didn't check
it in. What systems have you compiled this on? (or rather, which ones not?) Did
you build the windows install?

I'll sleep on it to see if something comes to mind before I review. On the
surface looks good, except for the vague worry.

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 145955 [details] [diff] [review]
make NR_RegOpen use const char*

r/sr=dveditz

Comment 4

[Benjamin Smedberg]

fixed-on-trunk

Comment 5

[Benjamin Smedberg]

Comment on attachment 145955 [details] [diff] [review]
make NR_RegOpen use const char*

Need this for firefox profile-import stuff on the 1.7 branch.

Comment 6

[Benjamin Smedberg]

Comment on attachment 145955 [details] [diff] [review]
make NR_RegOpen use const char*

We made a firefox branch, don't need approvals.