Closed
Bug 240458
Opened 22 years ago
Closed 22 years ago
js_DecompileValueGenerator doesn't take a JSBool
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: caillon, Assigned: caillon)
Details
Attachments
(1 file)
|
960 bytes,
patch
|
Details | Diff | Splinter Review |
While passing JS_FALSE does work (since it is equivalent to 0 and currently
translates to JSDVG_IGNORE_STACK), passing it here is not really cool, and
momentarily confusing to the reader (in this case, me).
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
||
Comment 2•22 years ago
|
||
Fixed.
/be
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 146068 [details] [diff] [review]
proposed patch
Brendan, this looks to be your code. Could you have a look and -- since I
don't believe I have access to this partition -- commit?
Attachment #146068 -
Flags: superreview?(brendan)
Attachment #146068 -
Flags: review?(brendan)
|
|
Assignee | |
Comment 4•22 years ago
|
||
Comment on attachment 146068 [details] [diff] [review]
proposed patch
You're too fast for me, brendan. ;-)
Attachment #146068 -
Flags: superreview?(brendan)
Attachment #146068 -
Flags: review?(brendan)
You need to log in
before you can comment on or make changes to this bug.
Description
•