240458 - js_DecompileValueGenerator doesn't take a JSBool

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

While passing JS_FALSE does work (since it is equivalent to 0 and currently
translates to JSDVG_IGNORE_STACK), passing it here is not really cool, and
momentarily confusing to the reader (in this case, me).

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: proposed patch

Comment 2

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 146068 [details] [diff] [review]
proposed patch

Brendan, this looks to be your code.  Could you have a look and -- since I
don't believe I have access to this partition -- commit?

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 146068 [details] [diff] [review]
proposed patch

You're too fast for me, brendan.  ;-)