Closed
Bug 240498
Opened 21 years ago
Closed 21 years ago
FreeType 2.1.8 compilation error
Categories
(Core Graveyard :: GFX: Gtk, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peter.kovar, Assigned: blizzard)
Details
(Keywords: fixed1.7)
Attachments
(1 file)
641 bytes,
patch
|
blizzard
:
review+
blizzard
:
superreview+
asa
:
approval1.7+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040412
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040412
Compilation w/ FreeType failed due to wrong order of headers. Attached is the
simple patch.
#include "nsIFreeType2.h"
#include FT_CACHE_IMAGE_H
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Reporter | ||
Comment 1•21 years ago
|
||
Assignee: roland.mainz → blizzard
Component: GFX: Xlib → GFX: Gtk
QA Contact: timeless → ian
Attachment #146096 -
Flags: superreview?(blizzard)
Attachment #146096 -
Flags: review?(blizzard)
Assignee | ||
Updated•21 years ago
|
Attachment #146096 -
Flags: superreview?(blizzard)
Attachment #146096 -
Flags: superreview+
Attachment #146096 -
Flags: review?(blizzard)
Attachment #146096 -
Flags: review+
Comment 2•21 years ago
|
||
I checked this patch in, assuming you don't have cvs access
Checking in nsFreeType.h;
/cvsroot/mozilla/gfx/src/freetype/nsFreeType.h,v <-- nsFreeType.h
new revision: 1.16; previous revision: 1.15
done
Updated•21 years ago
|
Attachment #146096 -
Flags: approval1.7?
Comment 3•21 years ago
|
||
Comment on attachment 146096 [details] [diff] [review]
change order of headers
a=asa (on behalf of drivers) for checkin to 1.7
Attachment #146096 -
Flags: approval1.7? → approval1.7+
Comment 4•21 years ago
|
||
also checked in on 1.7 branch:
Checking in nsFreeType.h;
/cvsroot/mozilla/gfx/src/freetype/nsFreeType.h,v <-- nsFreeType.h
new revision: 1.15.2.1; previous revision: 1.15
done
Thanks for the patch Peter!
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•