240502 - Checkin for Bug 116376 breaks AIX build (wait.h not found)

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Philip K. Warren]

The checkin for Bug 116376 has broken the AIX Tinderbox. See the following:

"/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/xpinstall/wizard/unix/src2/nsSetupTypeDlg.cpp",
line 48.10: 1540-0836 (S) The #include file <wait.h> is not found.

AIX does not have a <wait.h> header file - the wait function is defined in
<sys/wait.h>. On Fedora Core 1, the <wait.h> header file simply includes
<sys/wait.h>, and "man 2 wait" specifies that <sys/wait.h> contains the
definition for the wait function. On a Solaris 9 system, the man page for the
wait function call specifies that it is declared in <sys/wait.h>, even though
<wait.h> exists.

I think <wait.h> should be changed to <sys/wait.h> in nsSetupTypeDlg.cpp.

Comment 1

[Philip K. Warren]

AIX documentation for wait():

http://www16.boulder.ibm.com/doc_link/en_US/a_doc_lib/libs/basetrf2/wait_waitpid_wait3_wait364.htm

Comment 2

[Andrew Schultz]

Attachment: patch

==> sys/wait.h

I used sys/wait.h in bug 57089, but not for bug 116376.  ugh.

Comment 3

[Andrew Schultz]

Comment on attachment 146100 [details] [diff] [review]
patch

I got r=bsmedberg on IRC

Comment 4

[Philip K. Warren]

Fixed.

Checking in nsSetupTypeDlg.cpp;
/cvsroot/mozilla/xpinstall/wizard/unix/src2/nsSetupTypeDlg.cpp,v  <-- 
nsSetupTypeDlg.cpp
new revision: 1.27; previous revision: 1.26
done