240562 - In <nsStyleStruct.cpp>, [Unused variable `nsIFrame*parentFrame']

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Serge Gautherie (:sgautherie)]

From "Blamed Build Warnings / Linux brad Clobber":
{{
roc+

1.	content/shared/src/nsStyleStruct.cpp:74 (See build log excerpt)
	Unused variable `nsIFrame*parentFrame'

72 {
73   nscoord result = 0;
74   nsIFrame* parentFrame = aFrame->GetParent();
75 
76   switch (aCoord.GetUnit()) {
}}

Comment 1

[Serge Gautherie (:sgautherie)]

*** Bug 240563 has been marked as a duplicate of this bug. ***

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <nsStyleStruct.cpp> [Checked in: Comment 5]

Removing line 74:
{{
  74 roc+     3.54   nsIFrame* parentFrame = aFrame->GetParent();

  84 roc+     3.54	   nsIFrame* frame = aFrame->GetParent();
}}
Line 84 should be enough :->

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 146151 [details] [diff] [review]
(Av1) <nsStyleStruct.cpp>
[Checked in: Comment 5]


I have no compiler: Could you compile/test/review this patch ? Thanks.

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 146151 [details] [diff] [review]
(Av1) <nsStyleStruct.cpp>
[Checked in: Comment 5]

Absolutely!
r=[e-mail]

Comment 5

[[e-mail]]

Fix checked in.