Closed Bug 240767 Opened 21 years ago Closed 21 years ago

[FIX]Crash looking at style rules matching node in a display:none iframe

Categories

(Other Applications :: DOM Inspector, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7final

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

()

Details

(Keywords: crash)

Attachments

(1 file)

The problem is lack of error-checks. To reproduce, open the URL in the URL field in inspector, go down to the <p>, and try to view its style rules.
Attached patch PatchSplinter Review
Attachment #146332 - Flags: superreview?(bryner)
Attachment #146332 - Flags: review?(caillon)
Priority: -- → P1
Summary: Crash looking at style rules matching node in a display:none iframe → [FIX]Crash looking at style rules matching node in a display:none iframe
Target Milestone: --- → mozilla1.7final
Attachment #146332 - Flags: superreview?(bryner) → superreview+
Keywords: crash
Comment on attachment 146332 [details] [diff] [review] Patch r=caillon. I thought this was fixed already.
Attachment #146332 - Flags: review?(caillon) → review+
I think what we had fixed was nodes in display:none nodes, not nodes in document with no presshell... Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 219514 has been marked as a duplicate of this bug. ***
Product: Core → Other Applications
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: