240920 - random netwerk/base/ changes

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I was browsing through netwerk/base/ a bit... found some things that would be
good to change; mostly added documentation

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 146449 [details] [diff] [review]
patch

I'd also like to change the "result" parameter of the streamloaderobserver to
"[const,array,size_is(resultLength)]in octet result", but that will require
(simple) changes to all implementors of that interface, and I don't want to do
that right now...

Comment 3

[Darin Fisher]

Comment on attachment 146449 [details] [diff] [review]
patch


>+     * @param aContext
>+     *        Optional. Will be passed to the observer.

Specify that "Optional" means that it may be null?


Thanks biesi!

r+sr=darin

Comment 4

[Darin Fisher]

> I'd also like to change the "result" parameter of the streamloaderobserver to
> "[const,array,size_is(resultLength)]in octet result", but that will require
> (simple) changes to all implementors of that interface, and I don't want to do
> that right now...

file a bug for that?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, and filed Bug 241092 for the change from comment 2