240929 - make dialogs modal

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

The installer has various dialogs that require user input before the installer
can procede, but the main installer window is still active, so the user can try
to do other stuff (hit next, change dir, etc).  It's evil, but they do it.  In
some places, the installer tries to protect against this, but in most places it
doesn't.

These dialogs should just be modal, so the user can't do anything but deal with
the dialog before moving on.

Comment 1

[Andrew Schultz]

Attachment: patch

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 146462 [details] [diff] [review]
patch

r=dveditz

Comment 3

[Andrew Schultz]

Attachment: patch merged to trunk

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 147006 [details] [diff] [review]
patch merged to trunk

Yep.  I did some of this for the firefox gtk2 installer.  The only possible
reasons I could come up with for the old behavior is that old gtk versions
didn't support the modality hints, or that window managers didn't realiably
support them.  In either case, I think they're well-supported now.

Comment 5

[Andrew Schultz]

Attachment: patch to play nicely with bug 236294

this just doesn't include the changes to ShowCRCFailedDlg, which is getting
removed by bug 236294

Comment 6

[Andrew Schultz]

checked in by timeless